chore(build): rely on integrated setuptools_scm instead of manual call #2032
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
setuptools_scm automatically set the version attribute - manually setting it wrong
…ort errors on Read the Docs
SunsetWolf
changed the title
Collaborator
|
First of all, thank you for your contribution to However, there are some problems with the code you contributed:
Finally, thanks for your contribution. |
| try: | ||
| from ._version import version as __version__ | ||
| except ImportError: | ||
| __version__ = get_version(root="..", relative_to=__file__) |
Contributor
Author
There was a problem hiding this comment.
get_version shouldn’t be used at runtime - editable install should be used for doc building/testing
Collaborator
There was a problem hiding this comment.
Thank you for the coments, Can you fix this with a new pull request?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setuptools_scm automatically set the version attribute - manually setting it wrong
Description
Motivation and Context
How Has This Been Tested?
pytest qlib/tests/test_all_pipeline.pyunder upper directory ofqlib.Screenshots of Test Results (if appropriate):
Types of changes